tl; dr Trump did indeed, have (and has) an unusually (although not uniformly - something that we also must be mindful about) strong appeal among working class white voters for a Republican candidate, in spite of the fact that - like all Republican candidates - his voters still skewed toward the white and the affluent.
I'm confused, because I thought that's what the article itself said. So I'm unclear on where the disagreement is. It sounds like it's a difference in emphasis--a difference in where you put the "but"....
Silver: Yes, Trump's voters are poorer than the voters for other Republican candidates, *but* they're still wealthier than the average American.
You: Yes, Trump's voters are wealthier than the average American, *but* they're not as wealthy as those of other Republican candidates.
Where's the disagreement between those two propositions?