The War on Terror helped the GOP there but it still trended D. 2004 being a foreign policy dominated election (The only one since 1992) helped the GOP in many Affluent Suburbs that had been trending D.
If you see the trend line since 1996 this is how it goes
1996: R+10.45
2000: R+8.5
2004: R+5.8
2008: R+0.9
2012: Even
2016: D+3.2
I would say without the crash in 08 McCain probably narrowly wins Virginia in 2008 and its probably 3 points more Republican than nation as whole(He still loses the election as he still wins OH, IA and NV)
This is also interesting. Not much of a Democratic trend in 2012, but then again Republicans still had a lot of room for growth in the rural parts of the state, and Romney didn’t collapse in NOVA/Richmond suburbs/etc. like Trump. Still, it makes you wonder if the state was really winnable for Republicans in 2012 or if Romney's 4-point loss was actually an overperformance or at least a GOP best-case scenario that year.
Romney was probably the best Republican for the middle to upper middle class suburban voter that started to shift away from the GOP.